Migrate to new SwiftUI navigation types and make ChatChannel non-optional #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global channel is now ChatChannel.global rather than nil. Representing this without an optional has a few advantages, namely that it plays better with SwiftUI list selections (which appear grayed out if nil, despite this being a semantically valid value in our previous model) and that it lets us avoid nested optionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates to iOS 16's navigation types (
NavigationSplitViewandNavigationStack), along with representing the global channel withChatChannel.globalinstead ofnil, since this plays better with the new navigation types1 and is better design anyway. Unfortunately, it is also a breaking change in the protocol, since attaching a channel to messages is now mandatory, since the protocol is considered unstable, however, this shouldn't be too big of an issue.Footnotes
Otherwise the navigation links will appear grayed out ↩